WIP: UDP6 Fixes/Improvements #272
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
There are some oddities about the gateway.conf UDP6 multicast port in that it is used both for local port and remote port Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
|
I see the port is supposed to be set from the string but it seems to be set incorrectly |
|
I've probably not fixed this the right way. The problem seems to be the UDP6 void SensorNetAddress::setAddress(struct sockaddr_in6 *IpAddr) is called not int SensorNetAddress::setAddress(string* data) And thus the port isn't bring set (?) |
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
Previously the UDP6 multicast wasn't working. I've taken code from https://github.com/kyberpunk/paho.mqtt-sn.embedded-c/blob/master/MQTTSNGateway/src/linux/udp6/SensorNetwork.cpp This seems to fix the issue for me although I'm not entirely clear what's different in terms of addressing Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
ajlennon
force-pushed
the
ajl/fix-debug-ipv6-addr-output
branch
from
d0b4fb5 to
bd99ee2
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a bit unclear about the UDP6 multicast port as it's used for local binding and there seems to be an assumption that the same value should be used for remote port but I don't believe it was ever set.