Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allowing shared subscriber group topics to match #911

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nwest1
Copy link

@nwest1 nwest1 commented Jan 28, 2022

This looked to be a bug to me.

When I was configuring a client, and used $share/groupname/topic as the topic, no messages would be delivered.

I traced it down to here: https://github.com/eclipse/paho.mqtt.java/blob/master/org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/CommsCallback.java#L611

At that point, the message would have come from topic, which does not match $share/groupname/topic, and the message would be left undelivered.

possibly related #827

Thank you for your time!

Signed-off-by: Nathan West Nathan.West@target.com

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • This change is against the develop branch, not master.
  • You have signed the Eclipse ECA
  • All of your commits have been signed-off with the correct email address (the same one that you
    used to sign the CLA) Hint: use the -s argument when committing.
  • If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that
    you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.

Signed-off-by: Nathan West <Nathan.West@target.com>
@klausbetz
Copy link

@icraggs, @rdasgupt: Are there any plans to merge this PR?

This seems to be a rock-solid implementation of a MQTT Client.
It would be really helpful when this bug is fixed. Until now (v1.2.5) consumers of this package need to provide a custom callback just to get shared subscriptions to work.

@wilx
Copy link

wilx commented Feb 1, 2024

I have hit this exact issue today. The suggested patch looks like it should fix the issue. Why is this not merged yet?

@AseWhy
Copy link

AseWhy commented Nov 27, 2024

Perhaps the shared pool of $queue should also be taken into account? It seems that this patch does not provide for this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants