Revert "Change h2 dep to test scope" #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4080fcb. h2 is needed in compile scope so that integration tests in pass-support work.
This means this comment in #118 is relevant:
The only Security Vulnerability left is the h2 dependency vulnerability. Looks like this is a false positive and being flagged by bad info in OSS: OSSIndex/vulns#277. Not sure why it is showing up still, but pass-core h2 version is 2.3.232, which based on a couple sites I checked looks clean: https://deps.dev/maven/com.h2database%3Ah2/2.3.232. Also, pass-core uses h2 only for local non-production testing.