-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Checkstyle fixes and add test for DSpace metadata
- Loading branch information
1 parent
d0481d1
commit 5bf461e
Showing
4 changed files
with
151 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125 changes: 125 additions & 0 deletions
125
...core/src/test/java/org/eclipse/pass/deposit/provider/dspace/DSpaceMetadataMapperTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| package org.eclipse.pass.deposit.provider.dspace; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import java.net.URI; | ||
| import java.time.ZonedDateTime; | ||
| import java.time.format.DateTimeFormatter; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import com.jayway.jsonpath.DocumentContext; | ||
| import com.jayway.jsonpath.JsonPath; | ||
| import org.eclipse.pass.deposit.model.DepositManifest; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata.Article; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata.Journal; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata.Manuscript; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata.PERSON_TYPE; | ||
| import org.eclipse.pass.deposit.model.DepositMetadata.Person; | ||
| import org.eclipse.pass.deposit.model.DepositSubmission; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class DSpaceMetadataMapperTest { | ||
| @Test | ||
| public void testPatchWorkspaceItem() { | ||
| DSpaceMetadataMapper mapper = new DSpaceMetadataMapper("test.embargo.lift", "test.embargo.terms"); | ||
|
|
||
| DepositSubmission ds = new DepositSubmission(); | ||
| DepositManifest manifest = new DepositManifest(); | ||
| DepositMetadata md = new DepositMetadata(); | ||
|
|
||
| ds.setManifest(manifest); | ||
| ds.setMetadata(md); | ||
|
|
||
| Article article = md.getArticleMetadata(); | ||
| Journal journal = md.getJournalMetadata(); | ||
| Manuscript manuscript = md.getManuscriptMetadata(); | ||
|
|
||
| manuscript.setTitle("this is a title"); | ||
| manuscript.setMsAbstract("This is a compelling abstract."); | ||
| journal.setJournalTitle("journal title"); | ||
| journal.setPublisherName("publisher name"); | ||
| article.setDoi(URI.create("10.1016/j.iheduc.2015.08.004")); | ||
| article.setIssue("1"); | ||
| article.setVolume("2"); | ||
|
|
||
| Person author1 = new Person(); | ||
| author1.setEmail("p1@example.com"); | ||
| author1.setFirstName("P1"); | ||
| author1.setFullName("P1 Person"); | ||
| author1.setLastName("Person"); | ||
| author1.setMiddleName("One"); | ||
| author1.setType(PERSON_TYPE.author); | ||
|
|
||
| Person author2 = new Person(); | ||
| author2.setEmail("p2@example.com"); | ||
| author2.setFirstName("P2"); | ||
| author2.setFullName("P2 Person"); | ||
| author2.setLastName("Person"); | ||
| author2.setMiddleName("Two"); | ||
| author2.setType(PERSON_TYPE.author); | ||
|
|
||
| md.getPersons().add(author1); | ||
| md.getPersons().add(author2); | ||
|
|
||
| ZonedDateTime pubDate = ZonedDateTime.now(); | ||
| ZonedDateTime embargoDate = pubDate.plusYears(1); | ||
|
|
||
| journal.setPublicationDate(pubDate); | ||
| article.setEmbargoLiftDate(embargoDate); | ||
|
|
||
| ds.setSubmissionDate(pubDate); | ||
|
|
||
| String json = mapper.patchWorkspaceItem(ds); | ||
|
|
||
| DocumentContext jsonContext = JsonPath.parse(json); | ||
|
|
||
| checkValue(jsonContext, "dc.title", manuscript.getTitle()); | ||
| checkValue(jsonContext, "dc.identifier.doi", article.getDoi().toString()); | ||
| checkValue(jsonContext, "dc.description.abstract", manuscript.getMsAbstract()); | ||
| checkValue(jsonContext, "dc.publisher", journal.getPublisherName()); | ||
| checkValue(jsonContext, "dc.identifier.citation", | ||
| "Person, P1 One, Person, P2 Two. (2024-12-19). journal title. 2 (1). 10.1016/j.iheduc.2015.08.004."); | ||
| checkValue(jsonContext, "dc.contributor.author", "P1 Person", "P2 Person"); | ||
| checkValue(jsonContext, "dc.date.issued", | ||
| journal.getPublicationDate().format(DateTimeFormatter.ISO_LOCAL_DATE)); | ||
| checkValue(jsonContext, "test.embargo.lift", | ||
| article.getEmbargoLiftDate().format(DateTimeFormatter.ISO_LOCAL_DATE)); | ||
| checkValue(jsonContext, "test.embargo.terms", | ||
| article.getEmbargoLiftDate().format(DateTimeFormatter.ISO_LOCAL_DATE)); | ||
| } | ||
|
|
||
| private void checkValue(DocumentContext context, String key, String... expected) { | ||
| String path = "$[?(@.path == '/sections/traditionalpageone/" + key + "')].value[*].value"; | ||
|
|
||
| List<String> values = context.read(path); | ||
|
|
||
| assertEquals(Arrays.asList(expected), values); | ||
| } | ||
|
|
||
| @Test | ||
| public void testPatchWorkspaceItemMinimalMetadata() { | ||
| DSpaceMetadataMapper mapper = new DSpaceMetadataMapper("test.embargo.lift", "test.embargo.terms"); | ||
|
|
||
| DepositSubmission ds = new DepositSubmission(); | ||
| DepositManifest manifest = new DepositManifest(); | ||
| DepositMetadata md = new DepositMetadata(); | ||
| Journal journal = md.getJournalMetadata(); | ||
|
|
||
| ds.setManifest(manifest); | ||
| ds.setMetadata(md); | ||
|
|
||
| Manuscript manuscript = md.getManuscriptMetadata(); | ||
| ZonedDateTime pubDate = ZonedDateTime.now(); | ||
|
|
||
| manuscript.setTitle("this is a title"); | ||
| journal.setPublicationDate(pubDate); | ||
|
|
||
| String json = mapper.patchWorkspaceItem(ds); | ||
|
|
||
| DocumentContext jsonContext = JsonPath.parse(json); | ||
|
|
||
| checkValue(jsonContext, "dc.title", manuscript.getTitle()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters