Fix #643: class names shortened and number of tests trimmed a bit #746
Conversation
Signed-off-by: Jeen Broekstra <jeen.broekstra@gmail.com>
|
@hmottestad I know you had a preference to have the "ForwardChaining..." bit in there, but there are other/better ways to inform our users about this new reasoner, and it was also not quite accurate (given that 'forward chaining' is something that applies to rule-based inferencers, and this new reasoner is not, strictly speaking, rule-based). |
| import org.junit.Rule; | ||
| import org.junit.rules.TemporaryFolder; | ||
|
|
||
| public class NativeStoreInferencingTestForwardChainingSchemaCachingRDFSInferencer extends InferencingTest { |
There was a problem hiding this comment.
This would never have been run as its classname doesn't end in Test or TestCase
|
Forward chaining is accurate. It first forward chaines the tbox into lookup tables, and then uses that to forward chain inferences on each inserted triple. The difference between this forward chaining and the one done by a rule engine is that I cache parts of the "chain" so that that part doesn't need to forward chained again each time data is added. Also, with forward chaining all the inferred triples are generated at insertion time. Which is the case for this reasoner. |
|
Anyhow, it is a very long and unwieldy name. |
|
Can you change it to "RDFSInferencer". The fact that is uses schema caching for optimisation doesn't necessarily need to be a part of the name. And if we add more things to the reasoner to make it faster or more concurrent, then we don't have to change the name again. |
|
or RDFSReasoner |
|
The problem with that is that it doesn't distinguish it sufficiently from the existing (forward chaining) inferencer. I'm also out of time - release is today and I need to get this merged. I suspect that once we have things stable and tested "in the field" a bit more, we'll do a refactor of this stuff anyway, hopefully we can fit that in for the next major release. |
This PR addresses GitHub issue: #643 .
Briefly describe the changes proposed in this PR:
ForwardChainingSchemaCachingRDFSInferencerrenamed toSchemaCachingRDFSInferencer: both shorter and more accurate