Simplify migration: Add AbstractDoValueMigrationHandlerByMap #1334
+173
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHuser
reviewed
Jan 28, 2025
| * possible old to new mappings. The {@link #initMigrationMap()} method is called only once during object | ||
| * initialization. | ||
| */ | ||
| public abstract class AbstractDoValueMigrationHandlerByMap<T> extends AbstractDoValueMigrationHandler<T> { |
There was a problem hiding this comment.
Maybe we could add a unit test? See DataObjectMigratorValueMigrationTest which includes multiple value migration handlers. We could add a migration handler similar to HouseTypeFixtureDoValueMigrationHandler_2, but based on the new AbstractDoValueMigrationHandlerByMap
There was a problem hiding this comment.
Added a test, what do you think about it?
matthiaso
force-pushed
the
features/mot/24.2/403145_instructionRenamingPermission
branch
2 times, most recently
from
d7cebe2 to
82a71b1
Compare
matthiaso
force-pushed
the
features/mot/24.2/403145_instructionRenamingPermission
branch
from
82a71b1 to
dcf2f7c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
403145