Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a warning for an autocomplete widget #4366

Closed
4 tasks done
AresEkb opened this issue Jan 6, 2025 · 0 comments · Fixed by #4367
Closed
4 tasks done

Fix a warning for an autocomplete widget #4366

AresEkb opened this issue Jan 6, 2025 · 0 comments · Fixed by #4367

Comments

@AresEkb
Copy link
Contributor

AresEkb commented Jan 6, 2025

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • latest
  • I have specified my environment :
  • my computer: Linux

Screenshots

No

Steps to reproduce

Open Chrome DevTools console

Open a details form containing an autocomplete widget

Expected behavior

There should not be any errors or warnings in the console

Actual behavior

There is the following warning in the console:

Warning: A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey, classes: ..., label: ..., data-testid: ..., icon: ..., clickable: ..., onClick: ..., className: ..., disabled: ..., data-tag-index: ..., tabIndex: ..., onDelete: ...};
  <ForwardRef(Chip2) {...props} />
React keys must be passed directly to JSX without using spread:
  let props = {classes: ..., label: ..., data-testid: ..., icon: ..., clickable: ..., onClick: ..., className: ..., disabled: ..., data-tag-index: ..., tabIndex: ..., onDelete: ...};
  <ForwardRef(Chip2) key={someKey} {...props} /> Error Component Stack
    at Autocomplete2 (Autocomplete.js:418:17)
    at ValuedReferenceAutocomplete (sirius-components-widget-reference.es.js:245:3)
    at div (<anonymous>)
    at RawReferencePropertySection (sirius-components-widget-reference.es.js:1937:3)
    at ReferencePropertySection (sirius-components-widget-reference.es.js:1928:3)
    at div (<anonymous>)
    at PropertySection (sirius-components-forms.es.js:14965:28)
    at div (<anonymous>)
    at div (<anonymous>)
    at Group (sirius-components-forms.es.js:15346:18)
    at div (<anonymous>)
    at Page (sirius-components-forms.es.js:15419:17)
    at div (<anonymous>)
    at Form (sirius-components-forms.es.js:15476:17)
    at sirius-components-forms.es.js:15686:31

Here is some details on the warning: mui/material-ui#39833

AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jan 6, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jan 7, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jan 7, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
sbegaudeau pushed a commit to AresEkb/sirius-web that referenced this issue Jan 14, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
sbegaudeau pushed a commit to AresEkb/sirius-web that referenced this issue Jan 14, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
@sbegaudeau sbegaudeau linked a pull request Jan 14, 2025 that will close this issue
39 tasks
@sbegaudeau sbegaudeau added this to the 2025.2.0 milestone Jan 14, 2025
@sbegaudeau sbegaudeau self-assigned this Jan 14, 2025
sbegaudeau pushed a commit to AresEkb/sirius-web that referenced this issue Jan 14, 2025
Bug: eclipse-sirius#4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
sbegaudeau pushed a commit that referenced this issue Jan 14, 2025
Bug: #4366
Signed-off-by: Denis Nikiforov <denis.nikif@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants