Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[security] upgrade lerna from 4.x to 5.x #11737

Closed
marcdumais-work opened this issue Oct 5, 2022 · 0 comments · Fixed by #11738
Closed

[security] upgrade lerna from 4.x to 5.x #11737

marcdumais-work opened this issue Oct 5, 2022 · 0 comments · Fixed by #11738
Labels
dependencies pull requests that update a dependency file enhancement issues that are enhancements to current functionality - nice to haves

Comments

@marcdumais-work
Copy link
Contributor

Bug Description:

ATM we use an older version of lerna (4.x) as a dev-dependency in Theia. This dependency is propagated to all Theia-based products, for development (not runtime - end-users of Theia-based IDEs are not affected).

According to "yarn audit", all our high and critical vulnerabilities (2 of each) are recursive dependencies of lerna. Upgrading to lerna v5.x would probably clear those vulnerabilities.

Steps to Reproduce:

  1. In the Theia repo root, run: >$ yarn audit --level high
  2. In the output (also see below), confirm that lerna dependencies are the cause of the high and critical (dev-)dependency vulnerabilities.

Additional Information

Here is a screenshot of the full yarn audit output (the ASCII copy&paste does not render well here):
image

@marcdumais-work marcdumais-work added enhancement issues that are enhancements to current functionality - nice to haves dependencies pull requests that update a dependency file labels Oct 5, 2022
marcdumais-work added a commit that referenced this issue Oct 5, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Oct 11, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Oct 11, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Oct 11, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Oct 11, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue Oct 11, 2022
Fixes #11737

before update:
7 vulnerabilities found - Packages audited: 1946
Severity: 3 Moderate | 2 High | 2 Critical

after update:
2 vulnerabilities found - Packages audited: 2036
Severity: 1 Moderate | 1 High

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies pull requests that update a dependency file enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant