Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[vscode] update Terminal.sendText(string, boolean?) parameter - parameter renaming #13235

Closed
rschnekenbu opened this issue Jan 3, 2024 · 0 comments · Fixed by #13236
Closed

[vscode] update Terminal.sendText(string, boolean?) parameter - parameter renaming #13235

rschnekenbu opened this issue Jan 3, 2024 · 0 comments · Fixed by #13236
Milestone
1.46.0

Comments

@rschnekenbu
Copy link
Contributor

Parameter of the method Terminal.sendText(text: string, addNewLine?: boolean) should be renamed to remain align with vscode.d.ts (addNewLine was changed to shouldExecute).
Current behavior was not changed, only a new line is still added when shouldExecute is true.
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 3, 2024
@rschnekenbu
Rename Terminal.sendText addNewLine parameter to align with vscode api
59f037d 
fixes eclipse-theia#13235

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Jan 3, 2024
Merged
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 3, 2024
@rschnekenbu
Rename Terminal.sendText addNewLine parameter to align with vscode api
ed37e55 
fixes eclipse-theia#13235

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Jan 8, 2024
Closed
5 tasks
@rschnekenbu rschnekenbu changed the title [vscode] update Terminal.sendText(string, boolean?) parameter (renaming) [vscode] update Terminal.sendText(string, boolean?) parameter - parameter renaming Jan 8, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Jan 16, 2024
@rschnekenbu
Rename Terminal.sendText addNewLine parameter to align with vscode api
f418006 
fixes eclipse-theia#13235

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
JonasHelming pushed a commit that referenced this issue Jan 16, 2024
@rschnekenbu
Rename Terminal.sendText addNewLine parameter to align with vscode api (
15caac5 
#13236)

fixes #13235

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46.0
Development

Successfully merging a pull request may close this issue.

Rename Terminal.sendText addNewLine parameter to align with vscode api eclipsesource/theia
2 participants
@rschnekenbu @jfaltermeier