force node-gyp version #11267
Merged
force node-gyp version #11267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly declare a dev-dependency on latest node-gyp to prevent Yarn from installing an arbitrary older version for building our native dependencies.
paul-marechal
added
bug
|
Related #11235 (comment) |
|
I've opened the IP Due Diligence issues: |
vince-fugnitto
approved these changes
Jun 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly declare a dev-dependency on latest node-gyp to prevent
Yarn from installing an arbitrary older version for building our
native dependencies.
How to test
npx node-gyp -vshould return v9.0.0.It should be possible to run
yarn installon Windows with only the Visual Studio 2022 Build Tools installed.Review checklist
Reminder for reviewers