Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added CodeActionTriggerKind #11695

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Added CodeActionTriggerKind #11695

merged 2 commits into from
Sep 23, 2022

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Sep 23, 2022 •
edited
Loading

What it does

This fixes #11502
The CodeActiontriggerKind is now present in the CodeActionProvider.

How to test

  1. Download this little test extension
    code-action-test-ext-0.0.1.zip
    or create it here
  2. install it in theia and open a Markdown file
  3. open CodeActions anywhere

Bildschirmfoto 2022-09-23 um 10 46 52

The title contains the type of the CodeActionTrigger.

Review checklist

Reminder for reviewers

@msujew msujew added the vscode issues related to VSCode compatibility label Sep 23, 2022
vince-fugnitto
vince-fugnitto approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes work as expected, and re-generating our comparator now marks the API as supported 👍

packages/plugin-ext/src/main/browser/languages-main.ts Show resolved Hide resolved
@jbicker @vince-fugnitto
Update packages/plugin-ext/src/main/browser/languages-main.ts
38eb63a 
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@jbicker jbicker merged commit f11b661 into master Sep 23, 2022
@github-actions github-actions bot added this to the 1.30.0 milestone Sep 23, 2022
@jbicker jbicker deleted the jbicker/vscode-support-codeactioncontext-11502 branch September 23, 2022 13:50
@vince-fugnitto
Copy link
Member

@jbicker not a big issue but next time do you mind performing a squash and merge when there are multiple commits?

Screen Shot 2022-09-23 at 10 37 56 AM

@jbicker
Copy link
Contributor Author

jbicker commented Sep 23, 2022

@jbicker not a big issue but next time do you mind performing a squash and merge when there are multiple commits?

Sure, no problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.

[vscode] Support CodeActionContext#triggerKind
3 participants
@jbicker @vince-fugnitto @msujew