Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

navigator: update open containing folder command #12076

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes #12073.

The pull-request updates the OPEN_CONTAINING_FOLDER command simplifying the behavior, and also making it accessible by the tabbar context-menu similarly to VS Code.

How to test

  1. start the electron application with a workspace
  2. right-click a folder in the navigator, the option should exist to "open containing folder" (different names for different os')
  3. confirm the command works as intended
  4. open an editor
  5. right-click the editor's tabbar, the option should exist to "open containing folder"
  6. confirm the command works as intended
  7. de-select the editor in the navigator, confirm that step 5 still works
  8. open a regular widget in the main-area or side-areas, confirm the command through right-click does not display

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit updates the `open containing folder` (known under different
names depending on the OS), so it can be used in the shell tabbar, and
it ultimately opens the resource in the user's fs explorer.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the navigator issues related to the navigator/explorer label Jan 16, 2023
@vince-fugnitto vince-fugnitto self-assigned this Jan 16, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added the electron issues related to the electron target label Jan 16, 2023
@ouliuquan
Copy link

This efficiency is really amazing👍

@vince-fugnitto vince-fugnitto merged commit 339de2d into master Jan 23, 2023
@vince-fugnitto vince-fugnitto deleted the vf/open-containing-folder branch January 23, 2023 13:36
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
electron issues related to the electron target navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Reveal in File Explorer" to tab bar context menu
3 participants