style: sidepanel styling - hidden title quick fix #12077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernandoAscencio
force-pushed
the
fa/widgetTitleFix
branch
from
4050d00 to
4044668
Compare
vince-fugnitto
requested changes
Jan 17, 2023
This commit aims to fix the issue of titles being totally occluded when the sidebar is dragged to its minimum width. Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
FernandoAscencio
force-pushed
the
fa/widgetTitleFix
branch
from
4044668 to
9f8ea2f
Compare
vince-fugnitto
approved these changes
Jan 17, 2023
vince-fugnitto
added
the
ui/ux
This was referenced Mar 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to fix the issue of titles being totally occluded when the sidebar is dragged to its minimum width.
Signed-off-by: FernandoAscencio fernando.ascencio.cama@ericsson.com
What it does
Fix #10666
This commit adds a min-width to
. Seen below:
.theia-sidepanel-title. Preventing the Title width from being reduced to nothing. However, this will make it so that the tabs on the right of the title will slowly disappear. Most of those commands are still accessible through theIf this behavior is not desirable, you can change the
min-widthinpackages\core\src\browser\style\dockpanel.cssThis will change how small the sidepanel can get. Possibly preventing the tabs from disapearing.
From testing with VSCode, something similar must happen with their sidebar as the title for the
Run and Debugmenu also disappears once the sidebar is too small. This does not implement the collapsing sidebar element in VSCode.How to test
Test should be the same as #10666.
Review checklist
Reminder for reviewers