Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tab API Implementation (#12109) #12142

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Feb 3, 2023

What it does

This is a back-port of #12109 into the community release. For testing and description, see the original PR.

How to test

see #12109

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Co-authored-by: Jan Bicker <jan.bicker@typefox.io>
Co-authored-by: Paul Maréchal <paul.marechal@ericsson.com>
@tsmaeder tsmaeder requested review from jbicker and tortmayr February 3, 2023 10:48
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the test extension for the original PR works as expected 👍

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Feb 3, 2023

Thx @msujew

@tsmaeder tsmaeder merged commit 4a019b3 into eclipse-theia:1.34-community-2023-02 Feb 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants