Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX 12154: add margin between input and text #12158

Merged

Conversation

nnacin
Copy link
Contributor

@nnacin nnacin commented Feb 7, 2023

What it does

Closes: #12154.

The pull-request fixes an issue with the styling of the WorkspaceInputDialog, namely between the content and input field:

Screenshot 2023-02-07 at 22 47 05

How to test

Follow steps from #12154.

Review checklist

Reminder for reviewers

@nnacin
Copy link
Contributor Author

nnacin commented Feb 7, 2023

#12154

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

nnacin and others added 2 commits February 7, 2023 22:37
Signed-off-by: Natali <natali.nacinovic@typeform.com>
Signed-off-by: Natali <natali.nacinovic@gmail.com>
@nnacin nnacin closed this Feb 7, 2023
@nnacin nnacin reopened this Feb 7, 2023
@nnacin nnacin marked this pull request as ready for review February 8, 2023 08:58
@nnacin nnacin requested a review from vince-fugnitto February 8, 2023 09:03
@vince-fugnitto vince-fugnitto added the dialogs issues related to dialogs label Feb 8, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the changes work well 👍

@vince-fugnitto vince-fugnitto merged commit 52d6e87 into eclipse-theia:master Feb 8, 2023
@nnacin nnacin deleted the fix-12154/dialog-styling branch February 8, 2023 22:20
@vince-fugnitto vince-fugnitto added this to the 1.35.0 milestone Feb 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dialogs issues related to dialogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dialog: fix 'new file' and 'new folder' dialog styling
2 participants