webview: add support for activeWebviewPanelId
#12182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
vscode
vince-fugnitto
force-pushed
the
vf/activeWebviewPanelId
branch
from
7df1167 to
77ac41e
Compare
vince-fugnitto
changed the title
activeWebviewPanelIdactiveWebviewPanelId
msujew
approved these changes
Feb 22, 2023
packages/plugin-ext/src/main/browser/webview/webview-context-keys.ts
Outdated
Show resolved
Hide resolved
The commit adds support for the `activeWebviewPanelId` when-context-clause. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Instead of having every `WebviewWidget` try to update the same context key, this commit adds a new component that listens for widget updates once and updates the context key accordingly.
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/activeWebviewPanelId
branch
from
7953978 to
9b47318
Compare
This was referenced Mar 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request adds support for the
activeWebviewPanelIdwhen context-clause which matches theviewTypeof the currently active webview panel.How to test
cat coding: start cat coding sessionactivewebviewpanelid.mp4
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com