Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix broken toolbar drag/drop behavior in dropzones #12257

Conversation

kenneth-marut-work
Copy link
Contributor

@kenneth-marut-work kenneth-marut-work commented Mar 3, 2023

What it does

Fixes #12256 by adding an onDragOver attribute to the toolbar's dropzones which points to the existing handleOnDragEnter handler. The addition of the lines below from #12065 in frontend-application.ts seem to have overridden the existing onDragEnter handler

image

How to test

Build this branch and try dragging a toolbar item in the toolbar's dropzones which can be found on the left/right sides of each toolbar column

Review checklist

Reminder for reviewers

Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reenables dropping on empty space in the toolbar. 👍

@colin-grant-work colin-grant-work merged commit ac15b73 into eclipse-theia:master Mar 3, 2023
@colin-grant-work colin-grant-work deleted the bugfix/toolbar-drag-and-drop branch March 3, 2023 16:32
@colin-grant-work colin-grant-work added this to the 1.36.0 milestone Mar 3, 2023
@vince-fugnitto vince-fugnitto added the toolbar issues related to the toolbar label Mar 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
toolbar issues related to the toolbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toolbar: drag and drop no longer works
3 participants