Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

playwright: Update to latest versions and add new page objects #12384

Merged
merged 1 commit into from
Apr 11, 2023
Merged

playwright: Update to latest versions and add new page objects #12384

merged 1 commit into from
Apr 11, 2023

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Apr 6, 2023

What it does

  • Update playwright to the latest version
    • Update test configuration to adapt to latest version
    • Remove obsolete multiple config files and scripts
  • Add page objects for OutputView, OutputChannel, Toolbar, MonacoEditor
  • Extend tests by testing the new page objects
  • Extend ExplorerView tests with compact folders
  • Extend QuickCommand tests
  • Update GETTING_STARTED.md and DEVELOPING.md
  • Update build script to use ensure clean and lint are called
    • Ensure all necessary playwright dependencies are installed on initial build

Signed-off-by: Nina Doschek ndoschek@eclipsesource.com

How to test

  • Run playwright tests via yarn test:playwright from root directory

Review checklist

Reminder for reviewers

@ndoschek ndoschek mentioned this pull request Apr 6, 2023
Closed
1 task
@ndoschek
Copy link
Contributor Author

ndoschek commented Apr 6, 2023

Hi @planger, as you already had an initial look on my changes, could you perhaps suggest additional reviewers for this PR? Thank you!

@planger
Copy link
Contributor

planger commented Apr 6, 2023

@vince-fugnitto Would you maybe have time to look into this change? I've already reviewed it internally.
Marc has done some work on Playwright recently as well, but I've already asked him to review #12381, so I don't want to overload him :-)

@vince-fugnitto vince-fugnitto added the playwright issues related to playwright tests label Apr 6, 2023
vince-fugnitto
vince-fugnitto approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I confirmed they pass locally and during CI 👍
I'm not sure if @marcdumais-work would like to take a look as well but given it works it is likely not necessary. We can keep an eye out if things get flaky.

@ndoschek ndoschek force-pushed the ndoschek/update-playwright branch from bfecfc9 to a2c6f06 Compare April 11, 2023 07:39
@ndoschek
playwright: Update to latest versions and add new page objects
45dc854 
- Update `playwright` to the latest version
  - Update test configuration to adapt to latest version
  - Remove obsolete multiple config files and scripts
- Add page objects for OutputView, OutputChannel, Toolbar, MonacoEditor
- Extend tests by testing the new page objects
- Extend ExplorerView tests with compact folders
- Extend QuickCommand tests
- Update GETTING_STARTED.md and DEVELOPING.md
- Update build script to use ensure clean and lint are called
  - Ensure all necessary playwright dependencies are installed on initial build

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
@ndoschek ndoschek force-pushed the ndoschek/update-playwright branch from a2c6f06 to 45dc854 Compare April 11, 2023 08:47
@planger
Copy link
Contributor

planger commented Apr 11, 2023

@vince-fugnitto Thanks for the review! Let's merge this PR then and observe the stability. I'll rebase #12381 where Marc is added as a reviewer on top to make sure both changes work in combination.

@planger planger merged commit 2b81f49 into eclipse-theia:master Apr 11, 2023
@vince-fugnitto
Copy link
Member

I was hoping to get #12320 in first due to issues with the "out-of-date" CI check but it's fine.

@ndoschek ndoschek deleted the ndoschek/update-playwright branch April 11, 2023 13:08
@planger
Copy link
Contributor

planger commented Apr 11, 2023

Oh I see... sorry about that! I saw that Nina rebased and all checks passed. So I thought I'd save the build cycle and rebase mine (as it is the smaller change anyway) :-)

@paul-marechal paul-marechal added this to the 1.37.0 milestone Apr 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
playwright issues related to playwright tests
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ndoschek @planger @vince-fugnitto @paul-marechal