Stub for proposed API: DocumentPaste #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate goal is for vscode built-in extension `vscode.markdown-language-features` v1.72.2 to work again (minus the "DocumentPaste" benefits. Fixes eclipse-theia#12430 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added
vscode
vince-fugnitto
approved these changes
May 10, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
DocumentPaste is a new proposed API. As of 1.72.2 it's only used in built-in extension
vscode.markdown-language-features.This commit adds a stub implementation, sufficient to use
vscode.markdown-language-features1.72.2 and hopefully later versions, if we need it to. The eventual goal is to replace this
stub with the full implementation.
Fixes #12430
How to test
Run the example application and confirm that build-in MarkDown support activates and works as
expected (the DocumentPaste-related features will not work, obviously). Some pointers:
Build the example application. Unzip the
markdown.zipfile below to an empty "plugins" folder at the root ofthe theia repo (or at least remove the older version of the markdown extensions, installed by
yarn download:plugins).markdown.zip
Do not run
yarn download:pluginsafter adding the vscode git extensions v1.72.2,since the command might install another version along, which might interfere with
the tests.
Review checklist
Reminder for reviewers