Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance shrinking behavior in view container part headers #12542

Closed
wants to merge 1 commit into from

Conversation

pisv
Copy link
Contributor

@pisv pisv commented May 17, 2023

What it does

Fixes #12541 by making labels in view container part headers shrinkable and disabling flex-shrinking for view container part title toolbars.

Before After
Screenshot Screenshot
Screenshot 2023-05-17 at 15 23 35 Screenshot 2023-05-17 at 17 29 18

How to test

Verify that enhanced shrinking in view container part headers works as expected and there are no regressions.

Review checklist

Reminder for reviewers

This commit makes labels in view container part headers shrinkable
and disables flex-shrinking for view container part title toolbars.

Fixes eclipse-theia#12541.
@vince-fugnitto
Copy link
Member

Sorry it looks like the pull-request fell under the cracks, I think it's fine to close in favor of #12542 and we can revisit the implementation if there are problems.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enhance shrinking behavior in view container part headers
2 participants