Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix plugin menu icon background on hover #12827

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 11, 2023

What it does

Closes #12826

Replaces the css rule on the icon element with a ::before element that emulates the same behavior. That leaves the background attribute on the icon element free to use ourselves.

How to test

Follow the instructions in #12826 to ensure that the behavior has been fixed.

Review checklist

Reminder for reviewers

@msujew msujew added plug-in system issues related to the plug-in system ui/ux issues related to user interface / user experience menus issues related to the menu labels Aug 11, 2023
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the instructions in #12826

I have verified (ed12938) the steps with the browser example. The fix worked. Thank you!

Before:

hover_menu__before.mp4

After:

hover_menu__after.mp4

The electron example does not yet show the icon.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I can confirm the icon display persists when hovering

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
menus issues related to the menu plug-in system issues related to the plug-in system ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Menu icon background gets overwritten on hover
3 participants