Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Inline breakpoint appears when deleting the last line code [#10874] #12832

Merged
merged 1 commit into from
Sep 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/debug/src/browser/editor/debug-editor-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,9 @@ export class DebugEditorModel implements Disposable {
const line = range.startLineNumber;
const column = range.startColumn;
const oldBreakpoint = this.breakpointRanges.get(decoration)?.[1];
const breakpoint = SourceBreakpoint.create(uri, { line, column }, oldBreakpoint);
const isLineBreakpoint = oldBreakpoint?.raw.line !== undefined && oldBreakpoint?.raw.column === undefined;
const change = isLineBreakpoint ? { line } : { line, column };
const breakpoint = SourceBreakpoint.create(uri, change, oldBreakpoint);
breakpoints.push(breakpoint);
lines.add(line);
}
Expand Down