vscode - proposed API evolution for TerminalQuickFixProvider for 1.82.0 #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschnekenbu
force-pushed
the
issues/12969-terminalQuickFixProvider
branch
from
251235a to
295bbfc
Compare
tsmaeder
approved these changes
Oct 21, 2023
note the API is still stubbed in the tool. Fixes eclipse-theia#12969 Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
tortmayr
force-pushed
the
issues/12969-terminalQuickFixProvider
branch
from
295bbfc to
9c65375
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix stubbed API with missing types and removed enums on 1.82.0 version for TerminalQuickFixProvider (used by npm builtins)
Fixes #12969
Contributed on behalf of ST Microelectronics
How to test
Not much, as this is a stubbed API.
Follow-ups
Review checklist
Reminder for reviewers