Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Keybindings to notebook editor #13497

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Mar 18, 2024

What it does

This adds multiple keybindings and refactors some stuff to make it easier to add new ones.
This builds ontop of #13448 so that needs to be merged first

Adds the following keybindings:

  • arrow up/down: change cell selection
  • enter: edit selected markdown cell
  • alt + enter: stop editing markdown cell
  • ctrl+enter: execute selected code cell
  • shift + enter: execute selected code cell and select the next
  • Alt+O: clear outputs
  • M: change selected code cell to markdown
  • Y: change selected markdown cell to code cell
  • A: Insert code cell above selected
  • B: Insert code cell below selected
  • d d: delete selected cell

How to test

Open or create a new notebook and test the keybindings

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden requested a review from jbicker March 18, 2024 10:49
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great! Thanks.

    this makes commands from jupyter available

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
remove unused inject
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden force-pushed the jiden/notebook-keybindings branch from 159f0f6 to 2e74302 Compare March 19, 2024 09:44
@jonah-iden jonah-iden marked this pull request as ready for review March 19, 2024 09:44
@jonah-iden jonah-iden merged commit 3e16157 into master Mar 19, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/notebook-keybindings branch March 19, 2024 10:16
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 19, 2024
@msujew msujew added keybindings issues related to keybindings notebook issues related to notebooks labels Apr 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
keybindings issues related to keybindings notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants