Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix MeasurementNotificationService binding #14439

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

tortmayr
Copy link
Contributor

What it does

Ensure that the MeasurementNotificationService identifer is bound in singleton scope.
Otherwise it can only be injected once i.e. if another service injects the MeasurementNotificationService
it would fail with an error like:

channel.ts:283 Uncaught (in promise) Error: Another channel with the id '/services/measurement-notification' is already open.
    at ChannelMultiplexer.open (channel.ts:283:19)
    at ServiceConnectionProvider.openChannel (service-connection-provider.ts:137:58)

How to test

Follow-ups

Review checklist

Reminder for reviewers

Ensure that the MeasurementNotificationService identifer is bound in
singleton scope.
Otherwise it can only be injected once
@tortmayr tortmayr requested a review from sdirix November 12, 2024 13:43
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tortmayr tortmayr merged commit cbe6b80 into eclipse-theia:master Nov 12, 2024
11 checks passed
@sdirix sdirix added this to the 1.56.0 milestone Nov 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants