Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve searchForDevontainerJsonFiles to not block server #14563

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Small improvement for the searchForDevontainerJsonFiles method

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew November 29, 2024 12:17
@msujew msujew changed the title improve searchForDevontainerJsonFiles to not block server Improve searchForDevontainerJsonFiles to not block server Dec 9, 2024
@msujew msujew added quality issues related to code and application quality dev-container labels Dec 9, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonah-iden jonah-iden merged commit fb09901 into master Dec 10, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/improve-devcontainer-file-search branch December 10, 2024 09:26
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev-container quality issues related to code and application quality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants