Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

core: add BackendApplicationServer #9461

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

paul-marechal
Copy link
Member

The BackendApplicationServer is an optional backend contribution that
serves frontend files. When not bound, the generators may bind one.

This component is useful when your application is packaged in such a way
that you need to customize how the frontend is served.

How to test

  1. Run the browser app example, the frontend should load like before.
  2. Shutdown the backend.
  3. Set an env var such as: SAMPLE_BACKEND_APPLICATION_SERVER=1
  4. Run the browser app example again, it should display SampleBackendApplicationServer OK

Review checklist

Reminder for reviewers

@paul-marechal paul-marechal added enhancement issues that are enhancements to current functionality - nice to haves core issues related to the core of the application labels May 10, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and work well.

When setting the SAMPLE_BACKEND_APPLICATION_SERVER=1 environment variable, the application restarts with the "SampleBackendApplicationServer OK" page.

@paul-marechal paul-marechal force-pushed the mp/backend-application-server branch from 1585a31 to 6cf6239 Compare May 31, 2021 16:36
The BackendApplicationServer is an optional backend contribution that
serves frontend files. When not bound, the generators may bind one.

This component is useful when your application is packaged in such a way
that you need to customize how the frontend is served.
@paul-marechal paul-marechal force-pushed the mp/backend-application-server branch from 6cf6239 to cc90acb Compare May 31, 2021 20:57
@paul-marechal paul-marechal merged commit 2880525 into master Jun 7, 2021
@paul-marechal paul-marechal deleted the mp/backend-application-server branch June 7, 2021 14:40
@github-actions github-actions bot added this to the 1.15.0 milestone Jun 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core issues related to the core of the application enhancement issues that are enhancements to current functionality - nice to haves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants