Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Background bookmarks #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatthewKhouzam
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam commented Feb 4, 2025

What it does

Changes the bookmarks widget to add the option to have background images. Fixes #211

How to test

  • Open a trace
  • Select an area
  • Press ctrl-d
  • Press OK
  • Select another area
  • press ctrl-d
  • Uncheck foreground
  • press OK
  • Compare.

Follow-ups

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Addresses bug 211

[Added] Ability to have background markers

Change-Id: Ie681f5577b5e9abdb8ebeb75c456f860625af1cb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
The original alpha made it harder to read.

[Changed] reduced default alpha on bookmarks

Change-Id: I692d19d51bef2fa4bf41b3b763e21547b89e9444
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks should not obstruct the trace
1 participant