fix: policy hub post and get policy rules response structuring and error mapping #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctusx#3) Added workflow for PR linting and updated PR template
- Added Github workflows for CI automation
…clipse-tractusx#17) Co-authored-by: Nitesh Sakhiya <37956326+niteshsakhiya@users.noreply.github.com> Co-authored-by: Arnab Kumar Nandy (Cofinity-X) <150015794+arnabcx@users.noreply.github.com>
…m chart structure (eclipse-tractusx#18) Co-authored-by: Arnab Kumar Nandy <arnab.nandy˛cofinity-x.com>
…cfx-1 feat: **R24.08** with application version `v1.1.0`
…ctusx#19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arnab Kumar Nandy <arnab.nandy˛cofinity-x.com> Co-authored-by: leandro-cavalcante <leandro.cavalcante@cofinity-x.com>
…olicy-Hub-POST/GET-Policy-Rules-Response-Structuring' into bugfix/Policy-Hub-POST-and-GET-Policy-Rules-Response-Structuring-and-error-mapping modified: src/hub/PolicyHub.Service/BusinessLogic/PolicyHubBusinessLogic.cs modified: src/hub/PolicyHub.Service/Controllers/PolicyHubController.cs modified: tests/hub/PolicyHub.Service.Tests/BusinessLogic/PolicyHubBusinessLogicTests.cs
leandro-cavalcante
deleted the
bugfix/Policy-Hub-POST-and-GET-Policy-Rules-Response-Structuring-and-error-mapping
branch
leandro-cavalcante
restored the
bugfix/Policy-Hub-POST-and-GET-Policy-Rules-Response-Structuring-and-error-mapping
branch
leandro-cavalcante
deleted the
bugfix/Policy-Hub-POST-and-GET-Policy-Rules-Response-Structuring-and-error-mapping
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the filter GET/POST for policyContent end point
Why
The current implementation of the GET/POST endpoint in the Policy Hub does not respond as expected when fetching a policy based on specific criteria. When a user makes a call to retrieve a policy rule with a precise value, such as through the following curl command:
curl -X 'GET'
'https://policy-hub.int.catena-x.net/api/policy-hub/policy-content?type=Usage&policyName=UsagePurpose&operatorType=Equals&value=DataExchangeGovernance%3A1.0'
The API is expected to return the specific policy rule that matches the input criteria. However, the endpoint is currently returning an optional attribute response instead of the expected policy rule response.
Issue
N/A
Checklist
Please delete options that are not relevant.
I have followed the contributing guidelines
I have performed a self-review of my own code
I have successfully tested my changes locally
I have added tests that prove my changes work
I have checked that new and existing tests pass locally with my changes