-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(clearingHouse): Integrate the Tagus Release V2 Api #1220
feat(clearingHouse): Integrate the Tagus Release V2 Api #1220
Conversation
518edc4
to
3d284f1
Compare
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/externalsystems/Clearinghouse.Library/BusinessLogic/ClearinghouseBusinessLogic.cs
Show resolved
Hide resolved
src/externalsystems/Clearinghouse.Library/BusinessLogic/ClearinghouseBusinessLogic.cs
Show resolved
Hide resolved
@tfjanjua you didn't checked the |
Hi @Phil91 , thanks for your feedback |
c17daab
to
f8d076a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did move the implicit client-side formating from the query to the business-logic adjusting the respective model-classes and unit-tests.
please also see my new review comments (and pull my changes before proceeding)
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/externalsystems/Clearinghouse.Library/BusinessLogic/ClearinghouseBusinessLogic.cs
Show resolved
Hide resolved
src/externalsystems/Clearinghouse.Library/BusinessLogic/ClearinghouseBusinessLogic.cs
Show resolved
Hide resolved
|
Description
Integration of the v2 api from Gaia-X Tagus release in company onboarding clearing house.
Why
v1 will be retired as of March 2025. Any API v1 calls will fail with a 400 HTTP Status Code.
Issue
Ref: 1217
Checklist