Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(errorHandling): adjust error handling to IExceptionFilter #1272

Merged
merged 3 commits into from
Feb 12, 2025
Merged

fix(errorHandling): adjust error handling to IExceptionFilter #1272

merged 3 commits into from
Feb 12, 2025

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 11, 2025

Description

Adjust the error handling from middleware to IExcecptionFilter

Why

The catch in the middleware wasn't catching the exception thrown in the controller

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 changed the title bugfix(errorHandling): adjust error handling to IExceptionFilter fix(errorHandling): adjust error handling to IExceptionFilter Feb 11, 2025
@Phil91 Phil91 force-pushed the bugfix/error-handling branch from 95ae887 to b46fc4e Compare February 11, 2025 13:34
@Phil91 Phil91 changed the base branch from main to release/v2.4.0-RC2 February 11, 2025 13:35
@Phil91
Copy link
Member Author

Phil91 commented Feb 11, 2025

@ntruchsess @evegufy fyi updated the version of the framework packages to 3.5.0 because we already have 3.4.0 in main.

@evegufy evegufy modified the milestone: Release 25.03 Feb 11, 2025
evegufy
evegufy approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM @ntruchsess could you please also review?

@ntruchsess ntruchsess force-pushed the bugfix/error-handling branch from b46fc4e to 10d1da9 Compare February 11, 2025 16:13
@ntruchsess ntruchsess force-pushed the bugfix/error-handling branch from 10d1da9 to 1fb7904 Compare February 11, 2025 16:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ntruchsess
Copy link
Contributor

@Phil91 : I did add a commit - please double check before merging

@Phil91 Phil91 merged commit fb0c660 into release/v2.4.0-RC2 Feb 12, 2025
10 checks passed
@Phil91 Phil91 deleted the bugfix/error-handling branch February 12, 2025 07:09
@ntruchsess ntruchsess mentioned this pull request Feb 13, 2025
Merged
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy evegufy approved these changes

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @evegufy