Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(errorHandling): readd error handling middleware #1276

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 13, 2025

Description

Readd the error handling middleware for minimal apis

Why

minimal apis don't work with the IExceptionFilter therefor the middleware has been readied

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from ntruchsess February 13, 2025 08:30
@Phil91 Phil91 changed the base branch from main to release/v2.4.0-RC2 February 13, 2025 08:30
@Phil91 Phil91 force-pushed the bugfix/error-handling branch from 17fe52d to f7aad29 Compare February 13, 2025 08:34
@Phil91 Phil91 requested a review from ntruchsess February 13, 2025 08:35
@Phil91 Phil91 force-pushed the bugfix/error-handling branch from f7aad29 to e018faa Compare February 13, 2025 08:50
@Phil91 Phil91 changed the title fix(errorHandling): read error handling middleware fix(errorHandling): readd error handling middleware Feb 13, 2025
@Phil91 Phil91 force-pushed the bugfix/error-handling branch from e018faa to 40064b9 Compare February 13, 2025 08:55
@Phil91 Phil91 force-pushed the bugfix/error-handling branch from 83b2b60 to ed6172a Compare February 13, 2025 09:10
@ntruchsess ntruchsess force-pushed the bugfix/error-handling branch from bde94ae to 83fd3e0 Compare February 13, 2025 09:37
@ntruchsess ntruchsess added this to the Release 25.03 milestone Feb 13, 2025
@ntruchsess ntruchsess merged commit ecb7460 into release/v2.4.0-RC2 Feb 13, 2025
10 checks passed
@ntruchsess ntruchsess deleted the bugfix/error-handling branch February 13, 2025 09:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants