feat: implemented the backend for demand and capacity notifications 2.0 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...va/org/eclipse/tractusx/puris/backend/notification/logic/service/OwnNotificationService.java
Fixed
Show resolved
Hide resolved
...g/eclipse/tractusx/puris/backend/notification/logic/service/ReportedNotificationService.java
Fixed
Show resolved
Hide resolved
tom-rm-meyer-ISST
requested changes
May 28, 2024
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/security/SecurityConfig.java
Outdated
Show resolved
Hide resolved
| @ResponseBody | ||
| @Operation(summary = "Get all own notifications", description = "Get all own notifications. Optionally the partner can be filtered by its bpnl.") | ||
| public List<NotificationDto> getAllNotifications(Optional<String> partnerBpnl) { | ||
| if (partnerBpnl.isEmpty()) { |
There was a problem hiding this comment.
Please sanitize / pattern check partnerBpnl
.../java/org/eclipse/tractusx/puris/backend/notification/controller/NotificationController.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/domain/model/Notification.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/domain/model/Notification.java
Outdated
Show resolved
Hide resolved
...g/eclipse/tractusx/puris/backend/notification/logic/service/ReportedNotificationService.java
Fixed
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/domain/model/Notification.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/domain/model/Notification.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/logic/dto/NotificationDto.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/logic/dto/NotificationDto.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/puris/backend/notification/logic/dto/NotificationDto.java
Outdated
Show resolved
Hide resolved
I'm unsure what you mean regarding the BPNL sanitizing. Is the pattern check I added to the parameter not enough? |
Ah sorry, you're right. Got confused due to the outdated conversation. |
tom-rm-meyer-ISST
approved these changes
May 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #316
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: