-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Chore: Mandatory change in licensing #468
Chore: Mandatory change in licensing #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please also update NOTICE.md
in folders frontend
and backend
.
I meanwhile check if this change also influences the docker notice and the file ending of the documentation files (see comment, gonna ask tomorrow in office hour)
@eschrewe the questions pointed out will be adressed next week. For now no need to update
|
I updated the NOTICE.md in the backend folder. The frontend folder does not contain a NOTICE.md. Since we don't know for sure, whether individual NOTICE.md in /frontend and /backend folder are required at all, Malte decided that we leave the /frontend folder as it currently is and merge that branch in order to meet the deadline tomorrow. |
I will take over the review due to unavailability of tom-rm-meyer-ISST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The open points mentioned by @tom-rm-meyer-ISST and @eschrewe have to be considered but shouldn't block this PR.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: