Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Confusing behavior in tag-crates #11

Closed
fuzzypixelz opened this issue Mar 5, 2024 · 0 comments · Fixed by #12
Closed

Confusing behavior in tag-crates #11

fuzzypixelz opened this issue Mar 5, 2024 · 0 comments · Fixed by #12

Comments

@fuzzypixelz
Copy link
Member

Describe the release item

  • If one passes sets dry-run = true in tag-crates and also supplies a version number, then said number will be ignored.
  • If one doesn't supply anything, i.e. when dry-run = false and version is empty, then the actions fails.

To make this less confusing:

  1. Not supplying setting dry-run should default to a dry-run to avoid accidental live-runs, hence the options should be renamed to live-run and default to false.
  2. Not supplying a version should default to auto-generating it from git-describe no matter if live-run is true or false.

This will allow for the simple case of not supplying anything to be a live-run with an auto-generated version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant