Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] consider rust-toolchain.yaml when building from other directory #618

Closed
milyin opened this issue Aug 23, 2024 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@milyin
Copy link
Contributor

milyin commented Aug 23, 2024

Describe the bug

See fix #617
This fix makes ad-hoc update which fixes specific issue.
@yellowhatter commented that that the real cause of the problem is probably ignoring rust-toolchain.yaml when building from other directory. Need to be revised

To reproduce

System info

@milyin milyin added the bug Something isn't working label Aug 23, 2024
@yellowhatter
Copy link
Contributor

I faced the same error on RMW and fixed it occasionally by making 1.75 toolchain default. This is a sign that rust-toolchain.yaml is definitely ignored.

The official doc is not clear about this, but people say that Cargo respects rust-toolchain.yaml only in CWD

@yellowhatter
Copy link
Contributor

@milyin please talk to Martin Geoff ( @gmartin82 ) about this: ZettaScaleLabs@b84e333

@gmartin82
Copy link
Contributor

Also see this PR which copies the toolchain config file into the build directory to ensure cargo picks it up.

@milyin
Copy link
Contributor Author

milyin commented Sep 2, 2024

Validated with https://crates.io/crates/version_check library that requested compiler version is used

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants