Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing the redundency #268

Closed
OmerFarukBOUN opened this issue Oct 24, 2024 · 1 comment
Closed

Fixing the redundency #268

OmerFarukBOUN opened this issue Oct 24, 2024 · 1 comment

Comments

@OmerFarukBOUN
Copy link

Describe the feature

Config config = parse_args(argc, argv, {}, {{"key_expression", &expr}});

In this line the {"key_expression", &expr} part is redundant. In getargs.h, it parses this input but does nothing with it and this argument does not affect the "config" object. Since it is in the example codes, it makes the reader to believe it is necessary. There are more places that this was used.
Please delete these redundant parts.

@DenisBiryukov91
Copy link
Contributor

This part is not redundant, it is used to parse optional key_expression argument value into &expr.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants