CI fixes / improvements #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently [demoted to "pedantic" again](rust-lang/rust#107743) in 1.67.1, so one solution would be to just use another version for now. It does however seem likely that it will be reintroduced at some point, so applying the fix. rust-lang/rust-clippy#10265
* Handle empty license field * Instead of aborting on first issue, print all problematic licenses / crates * Add a bit more structure
|
Also pretty nice that it's possible to fix these things by just telling the Rust toolchain to do it :) $ cargo clippy --all-targets --fix -- -W warnings -D warnings -W clippy::uninlined_format_args
Compiling databroker-proto v0.3.1 (/home/john/src/boschglobal/kuksa.val/kuksa_databroker/databroker-proto)
Compiling databroker v0.3.1 (/home/john/src/boschglobal/kuksa.val/kuksa_databroker/databroker)
Fixed kuksa_databroker/databroker/build.rs (1 fix)
Checking databroker-examples v0.3.1 (/home/john/src/boschglobal/kuksa.val/kuksa_databroker/databroker-examples)
Checking databroker-cli v0.3.1 (/home/john/src/boschglobal/kuksa.val/kuksa_databroker/databroker-cli)
Fixed kuksa_databroker/databroker-cli/src/main.rs (21 fixes)
Fixed kuksa_databroker/databroker/src/vss.rs (2 fixes)
Fixed kuksa_databroker/databroker/src/broker.rs (1 fix)
Fixed kuksa_databroker/databroker/src/grpc/sdv_databroker_v1/broker.rs (1 fix)
Fixed kuksa_databroker/databroker/src/query/compiler.rs (8 fixes)
Fixed kuksa_databroker/databroker/src/query/executor.rs (14 fixes)
Fixed kuksa_databroker/databroker/src/grpc/kuksa_val_v1/val.rs (2 fixes)
Fixed kuksa_databroker/databroker-examples/examples/perf_subscriber.rs (3 fixes)
Fixed kuksa_databroker/databroker-examples/examples/perf_setter.rs (8 fixes)
Fixed kuksa_databroker/databroker/src/main.rs (2 fixes)
Finished dev [unoptimized + debuginfo] target(s) in 14.77s |
SebastianSchildt
approved these changes
Feb 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
clippy::uninlined_format_argslinthttps://rust-lang.github.io/rust-clippy/master/#uninlined_format_args
This lint was promoted from "pedantic" in Rust 1.67.0. It was subsequently demoted to "pedantic" again in 1.67.1, so one solution would be to just use another version for now.
rust-lang/rust#107743
It does however seem likely that it will be reintroduced at some point, so applying the fix now.
rust-lang/rust-clippy#10265
Better error messages in createbom