Add ISC & ring licenses #480
Conversation
argerus
commented
Feb 14, 2023
argerus
commented
- Update createbom to handle custom license files
- Add ISC & ring licenses
There was a problem hiding this comment.
Every entry in thirdparty_components now has a license_file": null entry, can we either supress that, or point it to the license we copied, i.e. ./something.txt.gz
(I have only tested for "standard licenses" so far, not yet with ring, but again, if there is license_file in there, make sure it points to whatever we copied in
argerus
force-pushed
the
feature/add_isc_and_ring_licenses
branch
from
f592bdc
to
e85a270
Compare
There was a problem hiding this comment.
Looking good now.
I noticed license for ring in JSON being "none" but It hink that is fine (as it is not declared for the crate, and I am not sure what else to put, if they don't provide a good SPDX string we should not make one up). The license_file points to the correct place
Also still detected when I tried sneaking in a not-whitelisted license.
Will merge after CI is green, unfortunately it seems Eclipse org runners are overcommitted again today
Unavailability of build runners will sometimes cause the ttl.sh images to expire before the integration test has a chance to run them.
argerus
force-pushed
the
feature/add_isc_and_ring_licenses
branch
from
e85a270
to
169ae61
Compare
