This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[eclipse/xtext#1569] Refactor Xtend to Java #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthoms
force-pushed
the
kt_issue1569_1
branch
from
0edd374 to
c8b99d5
Compare
szarnekow
suggested changes
Oct 29, 2019
...se.xtext/src/org/eclipse/xtext/parser/antlr/AbstractAntlrParserBasedTokenSourceProvider.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/parser/antlr/AbstractTokenSourceProvider.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/resource/ForwardingEObjectDescription.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/resource/ForwardingEObjectDescription.java
Outdated
Show resolved
Hide resolved
kthoms
force-pushed
the
kt_issue1569_1
branch
from
c8b99d5 to
263a1db
Compare
szarnekow
reviewed
Oct 29, 2019
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
tivervac
suggested changes
Oct 29, 2019
...se.xtext/src/org/eclipse/xtext/parser/antlr/AbstractAntlrParserBasedTokenSourceProvider.java
Outdated
Show resolved
Hide resolved
...se.xtext/src/org/eclipse/xtext/parser/antlr/AbstractAntlrParserBasedTokenSourceProvider.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledError.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledError.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
kthoms
force-pushed
the
kt_issue1569_1
branch
from
263a1db to
c8bc7c7
Compare
tivervac
suggested changes
Oct 30, 2019
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledError.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
|
There should be a cleanup action that allows to remove redundant parentheses and redundant modifiers. |
|
|
|
The "remove redundant modifiers" action does not remove final modifiers from parameters. How could this be decided that it might not be wanted? It removes e.g. 'public' on interface fields/methods. BTW: I have implemented this cleanup action :) I think we should configure those common cleanup actions on the projects with separate issue. |
No I don't think so. When we migrate the stuff to Java, the result should look nice and not like a second class citizen. |
|
Right. What I meant is: When we already agreed which cleanup actions make sense in general, then we could store these settings in the projects. For the migration it is clear that the resulting Java code should look nice as hand crafted, and applying the cleanup actions is just task to achieve this. |
kthoms
force-pushed
the
kt_issue1569_1
branch
from
c8bc7c7 to
3043dc2
Compare
tivervac
approved these changes
Nov 1, 2019
org.eclipse.xtext/src/org/eclipse/xtext/service/AllRulesCache.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.xtext/src/org/eclipse/xtext/service/OperationCanceledManager.java
Show resolved
Hide resolved
The usage of Xtend in the Xtext code base should be reduced where the usage of Xtend is not super beneficial. Replaced Xtend classes by the compiled code and refactored the code to more readable Java. Performed source cleanup action. Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
kthoms
force-pushed
the
kt_issue1569_1
branch
from
3043dc2 to
5703d41
Compare
|
@szarnekow I think all issues should be adressed now. Could you have a look again, please? |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of Xtend in the Xtext code base should be reduced where the
usage of Xtend is not super beneficial. Replaced Xtend classes by the
compiled code and refactored the code to more readable Java.
Signed-off-by: Karsten Thoms karsten.thoms@itemis.de