This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Make server-side layouting optional in EcoreModelFactory #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
reviewed
Jan 17, 2019
| @@ -70,8 +70,10 @@ public SModelRoot loadModel(ResourceSet resourceSet, URI sourceURI) { | |||
| LOGGER.error(e); | |||
| } | |||
|
|
|||
| EcoreLayoutEngine layoutEngine = new EcoreLayoutEngine(); | |||
| layoutEngine.layout(result); | |||
| if (serverSideLayout) { | |||
There was a problem hiding this comment.
Wouldn't it make sense to move the whole layouting into a separate method? so you would do:
var model = loadModel();
layoutModel(model);
There was a problem hiding this comment.
And shouldn't the whole Layoutengine initialization ElkLayoutEngine.initialize(new LayeredMetaDataProvider()); be part of this method?
|
Thanks for the feedback! Yes, you mean like in a6b4f41? Clients could then optionally invoke |
eneufeld
approved these changes
Jan 17, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.