Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

Prepare packages for publish #24

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Prepare packages for publish #24

merged 2 commits into from
Jan 31, 2019

Conversation

tortmayr
Copy link
Collaborator

@tortmayr tortmayr commented Jan 31, 2019 •
edited
Loading

This change updates client and server to the latest versions and incorporates the necessary changes
A short summary:
Ecore-sprotty:

Theia-Ecore:

  • Swap to latest glsp-theia-extension version (hardpinned) and refactor code accordingly
  • Custom diagram widget to enable server-side layouting and disable edit-specific modules like the tool-palette

Server:

@tortmayr tortmayr requested a review from eneufeld January 31, 2019 10:55
eneufeld
eneufeld approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/theia-ecore/sprotty-ecore/src/index.ts Outdated
export { createEcoreDiagramContainer }
export * from './model'
export * from './model'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the double export?

@tortmayr tortmayr merged commit 633b83b into master Jan 31, 2019
@tortmayr tortmayr mentioned this pull request Jan 31, 2019
Closed
@tortmayr tortmayr deleted the tortmayr/pre-release branch May 4, 2019 07:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @eneufeld