Skip to content

Commit

Permalink
dev: Update pnpm to latest v10.4.1 and fix Netlify build (#2422)
Browse files Browse the repository at this point in the history
- Update to lockfile version 9 without updating dependencies (Used by pnpm 9+ and 10+)
- Add npm corepack configuration for pnpm to latest version 10.4.1. This is also respected by Netlify fixing the build issues.
- Set engine version restriction for pnpm to ^10.4.1.
- Update dev container
- Update README
- ci: Use pnpm version from corepack's package.json property packageManager. This is supported by pnpm-setup action.
- ci: Update pnpm-setup action and pin version
  • Loading branch information
lucas-koehler authored Feb 25, 2025
1 parent 64fba38 commit daa1836
Show file tree
Hide file tree
Showing 6 changed files with 18,068 additions and 25,020 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ ENV CHROME_BIN=/usr/bin/chromium
# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"

# Install and configure pnpm
RUN su node -c "npm install -g pnpm@8"
RUN su node -c "npm install -g pnpm@10"
RUN su node -c "pnpm config set store-dir /home/node/.pnpm-store"
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,10 @@ jobs:
with:
node-version: 18

- uses: pnpm/action-setup@v4.0.0
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
name: Install pnpm
id: pnpm-install
with:
version: 8
run_install: false

- name: Build
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ jobs:
node-version: "18"
registry-url: "https://registry.npmjs.org"

- uses: pnpm/action-setup@v4.0.0
- uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
name: Install pnpm
id: pnpm-install
with:
version: 8
run_install: false

- name: "Install Packages"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Independently of the assigned milestone, contributions are always accepted and a
### First time setup

- Install [node.js](https://nodejs.org/) (only Node v18.19+ < 19 is currently supported)
- Install pnpm: <https://pnpm.io/installation> (use pnpm 8.6.2+)
- Install pnpm: <https://pnpm.io/installation> (use pnpm 10.4.1+) or use [corepack](https://nodejs.org/docs/latest-v18.x/api/corepack.html) to enable the recommended version
- Clone this repository
- Install dependencies: `pnpm i --frozen-lockfile`

Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"name": "jsonforms-monorepo",
"engines": {
"node": "^18.19.0",
"pnpm": ">=7.13.4"
"pnpm": "^10.4.1"
},
"packageManager": "pnpm@10.4.1+sha256.4b702887986995933d4300836b04d6d02a43bc72b52e4f7e93a4ca608b959197",
"scripts": {
"lerna": "lerna",
"preparePublish": "git clean -dfx && pnpm i --frozen-lockfile && pnpm run clean && pnpm run build && pnpm run doc && pnpm run test",
Expand Down
Loading

0 comments on commit daa1836

Please # to comment.