Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(material-renderers): add missing Mui-error class for some controls #2433

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

vishnutsivan
Copy link
Contributor

@vishnutsivan vishnutsivan commented Apr 4, 2025

  • Passing error prop for missing controls

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 9f53777
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67f5073bb65c3a00098fa873
😎 Deploy Preview https://deploy-preview-2433--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 8, 2025

Coverage Status

coverage: 82.517%. remained the same
when pulling 9f53777 on vishnutsivan:master
into 9acd631 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution aligning this with the other controls ❤️

Please remove the version update as explained inline :)

@@ -1,6 +1,6 @@
{
"name": "@jsonforms/material-renderers",
"version": "3.5.1",
"version": "3.5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. Version numbers are automatically increased when we release a new version via CI

Copy link
Contributor Author

@vishnutsivan vishnutsivan Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted. when can we expect new version?

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnutsivan Thanks for the update! This LGTM now.

The next regular release will probably be around end of May or in June. There is no fixed date, yet. However, we could do a pre-release (e.g. 3.6.0-alpha.0) this week.

@lucas-koehler lucas-koehler merged commit 28f36ed into eclipsesource:master Apr 8, 2025
8 checks passed
@lucas-koehler lucas-koehler added this to the 3.6 milestone Apr 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants