-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(material-renderers): add missing Mui-error class for some controls #2433
Conversation
vishnutsivan
commented
Apr 4, 2025
•
edited
Loading
edited
- Passing error prop for missing controls
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution aligning this with the other controls ❤️
Please remove the version update as explained inline :)
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@jsonforms/material-renderers", | |||
"version": "3.5.1", | |||
"version": "3.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this. Version numbers are automatically increased when we release a new version via CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted. when can we expect new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishnutsivan Thanks for the update! This LGTM now.
The next regular release will probably be around end of May or in June. There is no fixed date, yet. However, we could do a pre-release (e.g. 3.6.0-alpha.0) this week.