Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(src/Element.ts) Element type error #725

Closed
wants to merge 1 commit into from
Closed

fix(src/Element.ts) Element type error #725

wants to merge 1 commit into from

Conversation

lzxb
Copy link
Contributor

@lzxb lzxb commented Feb 24, 2021

Detail see: #724

@pissang
Copy link
Contributor

pissang commented Feb 24, 2021

Thanks! Seems getInsideTextFill and getOutsideFill also needs this change.

@lzxb
Copy link
Contributor Author

lzxb commented Feb 24, 2021

I tested it. No

@lzxb
Copy link
Contributor Author

lzxb commented Feb 24, 2021

I use it to develop a real-time chart, which is very good

@pissang
Copy link
Contributor

pissang commented Feb 24, 2021

I mean these methods are similar in design. Their returns should all be nullable.

@lzxb
Copy link
Contributor Author

lzxb commented Feb 25, 2021

I see you. Subclass inheritance can be reset to undefined

lzxb added a commit to lzxb/zrender that referenced this pull request Feb 25, 2021
@lzxb
Fix(ecomfe#725) type error
3f984f4
pissang added a commit that referenced this pull request Feb 25, 2021
@pissang
Merge pull request #726 from lzxb/patch-2
0c80b56 
fix(#725) type error
@pissang pissang closed this Feb 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzxb @pissang