Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: dynamic view gets #123

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: dynamic view gets #123

merged 2 commits into from
May 23, 2024

Conversation

Kelwan
Copy link
Contributor

@Kelwan Kelwan commented May 23, 2024

No description provided.

@Kelwan Kelwan changed the title feat/dynamic view gets feat: dynamic view gets May 23, 2024
Copy link
Member

@zaucy zaucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of this looks like it shouldn't compile. Maybe we missed these cases in our tests?

ecsact/entt/wrapper/dynamic.hh Show resolved Hide resolved
rt_entt_codegen/core/print_sys_exec.cc Show resolved Hide resolved
rt_entt_codegen/core/print_sys_exec.cc Outdated Show resolved Hide resolved
rt_entt_codegen/core/print_sys_exec.cc Show resolved Hide resolved
rt_entt_codegen/core/print_sys_exec.cc Show resolved Hide resolved
rt_entt_codegen/core/print_sys_exec.cc Show resolved Hide resolved
@zaucy zaucy enabled auto-merge May 23, 2024 18:50
@zaucy zaucy added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@zaucy zaucy changed the title feat: dynamic view gets fix: dynamic view gets May 23, 2024
@zaucy zaucy added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@Kelwan Kelwan added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
Copy link

cocogitto-bot bot commented May 23, 2024

✔️ a4faffd...5fc1d31 - Conventional commits check succeeded.

@Kelwan Kelwan added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit f45ca6c May 23, 2024
5 checks passed
@Kelwan Kelwan deleted the feat/dynamic-view-gets branch May 23, 2024 20:18
@zaucy zaucy mentioned this pull request Jul 3, 2024
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants