-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: dynamic view gets #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelwan
force-pushed
the
feat/dynamic-view-gets
branch
from
May 23, 2024 18:03
6763f10
to
a4faffd
Compare
zaucy
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of this looks like it shouldn't compile. Maybe we missed these cases in our tests?
zaucy
approved these changes
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 23, 2024
Kelwan
force-pushed
the
feat/dynamic-view-gets
branch
from
May 23, 2024 19:57
3090c4a
to
5fc1d31
Compare
✔️ a4faffd...5fc1d31 - Conventional commits check succeeded. |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.