Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Web API for listing, creating, archiving rooms #131

Merged
merged 16 commits into from
Mar 8, 2021

Conversation

mehtank
Copy link
Contributor

@mehtank mehtank commented Dec 31, 2020

Partially addresses #125

@mehtank mehtank mentioned this pull request Dec 31, 2020
@mehtank mehtank mentioned this pull request Jan 2, 2021
@edemaine edemaine mentioned this pull request Feb 10, 2021
9 tasks
@edemaine edemaine added the priority Need to work on this soon label Mar 3, 2021
@edemaine
Copy link
Owner

edemaine commented Mar 6, 2021

@mehtank Looking over this code, is there a particular reason you chose an API with specific actions like raiseHand and archiveRoom instead of the generic roomEdit/tabEdit interface that the methods use internally? It seems like the latter would be easier to maintain, and safe given our plan to require the meeting secret for all methods (and frankly exactly what's available in the browser anyway). The only downside is a somewhat less intuitive API, but I think easy enough...?

@mehtank
Copy link
Contributor Author

mehtank commented Mar 6, 2021

@mehtank Looking over this code, is there a particular reason you chose an API with specific actions like raiseHand and archiveRoom instead of the generic roomEdit/tabEdit interface that the methods use internally?

"Historical artifact" -- when I started on this, my main use case was to enable easy archiving of a whole bunch of rooms at once (to save on UI clicks). No idea why I didn't just unify it into a single edit endpoint when I added the raising / lowering hand bit later. I agree that a single roomEdit / tabEdit API call is better.

@mehtank
Copy link
Contributor Author

mehtank commented Mar 6, 2021

Oh I did unify them later over in the tags branch #135 (commit 4197733)

@edemaine
Copy link
Owner

edemaine commented Mar 7, 2021

@mehtank I did a major rewrite of the API (and a lot of the methods). Do you want to review it before it gets merged, to make sure it does everything you want? (sans tags for now) Notably, you can do cool match + edit queries like tabEdit with body {"tabs":{"meeting":"blahblah","archived":false}, "archived":true} — this matches all unarchived tabs and makes them archived. Could use documentation...

@edemaine edemaine linked an issue Mar 8, 2021 that may be closed by this pull request
@edemaine edemaine merged commit 971340f into edemaine:master Mar 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority Need to work on this soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API
2 participants