-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Hirize #160
base: master
Are you sure you want to change the base?
Hirize #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. There are some things missing. Most important, we need to make
pytest -m hirize
succeed. You have to add
from .hirize import HirizeApi
to edenai_apis/apis/__init__.py
This way, your api will be automatically tested
"file_name": file_name | ||
}) | ||
|
||
hirize_response = requests.request("POST", self.url, headers=self.headers, data=dumpData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be some error handling here, raising ProviderException. Problably also best to create a client.py, where the client requests are handled
import random | ||
import requests | ||
import json | ||
from .client import Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client doesnt exist
Hello appelstroop, after correcting my code, I sent it to you again. |
Hirize HR Contribute for eden.ai (hirize.hr)