Skip to content

feat: add recurring payments #40

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat: add recurring payments #40

wants to merge 37 commits into from

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Aug 16, 2023

No description provided.

tmigone added 20 commits June 29, 2023 17:05
@tmigone
feat: initial implementation using gelato
1173b38 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): make rp contract governed, add maxgasprice check, events, etc
797ba40 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat: refactor, add GelatoManager, SpookyBoo lib
9e6b711 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat: add RP interface
eb5af2f 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat: refactor to use generic billing contracts interface
4fff7f6 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: remove unused imports
ae721e5 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: rename BillingContract to PaymentType
182c0aa 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: add natspec comments
85f1907 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: more natspec
9707554 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat: make RP contract rescuable
5abab06 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): add mock contracts for unit tests and initial test suite
759e7ff 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
test: increase code coverage for rp contract
14734c1 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat: add more tests to rp
3e7a3c6 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): rework IPayment interface, include creation flag for more f…
ad32bbe 
…lexibility

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): change create function signature
013871d 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): add test suite for mock payment type
f0e8501 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): add billing contract tests with rp
2e68213 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): add billing tests for recurring payments
30c0683 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
feat(rp): add subscription mock and tests
b3e1c6c 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix(rp): billing tests missing param
b2883f5 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone changed the title WIP: recurring payments feat: add recurring payments Sep 4, 2023
@tmigone
test(rp): add more rp and subscriptions tests
560c333 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
Merge branch 'main' into tmigone/recurring-payments
2a43a58
@tmigone
chore: update solidity-coverage plugin
7911422 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix(rp): init rp last execution time at current time (0xM L-03) (#41)
90ef626 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage is 63.35% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
contracts/gelato/AutomateReady.sol 11.11%
contracts/libs/BokkyPooBahsDateTimeLibrary.sol 23.23%
contracts/gelato/AutomateTaskCreator.sol 36.84%
contracts/BanxaWrapper.sol 100.00%
contracts/Billing.sol 100.00%
contracts/BillingConnector.sol 100.00%
contracts/GelatoManager.sol 100.00%
contracts/RecurringPayments.sol 100.00%
contracts/Rescuable.sol 100.00%

📢 Thoughts on this report? Let us know!.

@tmigone
fix: when extending sub make sure user doesnt pay for time in the pas…
52d2a1d 
…t (0xM H-01) (#43)

* fix: when extending sub make sure user doesnt pay for time in the past (0xM H-01) 

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone changed the base branch from main to ariel/add-many September 19, 2023 13:35
@tmigone tmigone changed the base branch from ariel/add-many to main September 19, 2023 13:35
@tmigone
fix: store execution and expiration intervals in rp struct (0xM M-01) (…
09f9518 
…#44)

* fix: store execution and expiration intervals in rp struct (0xM M-01) 

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone tmigone changed the base branch from main to ariel/add-many September 19, 2023 13:39
@tmigone tmigone changed the base branch from ariel/add-many to main September 19, 2023 13:40
@tmigone
fix: prevent gas griefing attack (0xM M-02) (#45)
a04a82c 
fix: prevent gas griefing attack (0xM M-02)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: enforce interval invariants (0xM L-01) (#46)
106b01a 
* fix: enforce interval invariants (0xM L-01)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: revert when extending if amount is not multiple of rate (0xM L-0…
fa7aba0 
…2) (#47)

* fix: revert when extending if amount is not multiple of rate (0xM L-02)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: add additional checks to check() (0xM L-04) (#48)
347f6fa 
* fix: add additional checks to check() (0xM L-04)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: emit events in constructor (0xM Q-01) (#55)
01d4d9e 
* fix: emit events in constructor (0xM Q-01)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: change fee currency to eth (0xM Q-02) (#56)
d3a1cc0 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: attack where create flow could drain rp tokens (#57)
9e7d9e5 
* fix: attack where create flow could drain rp tokens

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: switch timekeeping from monthly to time based (0xM L-04) (#58)
810d750 
* fix: switch timekeeping from monthly to time based (0xM L-04)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: add testnet deployment files (#59)
ac989a8 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix: revert 0xM Q02 (#60)
43e6ce2 
* fix: revert 0xM Q02

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

* feat(rp): add rp management tasks and new rp address for arbgor

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

---------

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: update rp contract to use gelato functions (#64)
b1c3d46 
* chore: update rp contract to use gelato functions

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

* chore: add script to add balance to 1Balance

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>

---------

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmigone @codecov-commenter