Check thawing period before resolving dispute #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarmat
reviewed
Aug 18, 2021
| @@ -105,13 +123,21 @@ export class DisputeResolver { | |||
| @confirmResolve | |||
| async accept(disputeID: string, execute = false): Promise<void> { | |||
| log.info(`Accepting dispute ${disputeID}...`) | |||
| await this.commit(disputeID, DisputeResolution.Accept, execute) | |||
| if (await this.validateStatuteOfLimitations(disputeID)) { | |||
There was a problem hiding this comment.
This is good but I can see us refactoring it to include more conditions later, what do you think?
At a later point we can have a validateCharter() that does the limitations one, double jeopardy, etc. within the function, print the error and return. If all good then commits.
There was a problem hiding this comment.
I agree but I didn't want to over-engineer it until we see the need.
abarmat
approved these changes
Aug 18, 2021
goaaron
added a commit
that referenced
this pull request
Sep 23, 2021
…t blocks...coming up automate the creation of divergent blocks broken fix conflict with sqlalchemy version make the dispute stage an enum all apis v0 and insomnia requests cleanup and documentation on how to run the application remove debugger modify version of ipfshttpclient, change module name from web3 to w3 addendum to readme requirements container file and Makescripts Update README.md multi stage docker build. use poetry inside of docker Build dockerfile added cicd and k8s files run on updated k8s .github paths fix cicd context fix repo name moving some fields to enums. cleanup some async code base frontend for dispute portal foundation redux actions bump webpack, setup base dispute page expose get all disputes list disputes simplify state with zustand merge state updates swap out the stages of the dispute allows frontend to toggle the stages of the dispute swap state in the frontend prior to revalidation. revalidation still hits later sort, filter, visualize uploaded data dispute portal list events Fix rainbow Fix setup when the config file is not yet created Define files to use when publishing package Add bin and cleanup gitignore filter disputes by status (#13) * filter by status * Update README.md Simplify cli (#14) * remove dispute command and show help by default * update README.md * fix usage Add Economics section and fetch network settings (#15) Sort disputes by date (#16) v0.2.0 Add defaultDisplayName to indexer and fisherman (#17) Check thawing period before resolving dispute (#19) Support for multiple ids on show and improved styling (#20) * Support for multiple ids on show and improved styling * Replace treeify with object-treeify Add closing epoch startBlock and poi info (#21) v0.3.0 [#24] Fix show command (#25) v0.3.1 remove conf file testing deployment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closedAtEpochin red on the dispute if more than 2 thawing periods have elapsed since.